Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use std::optional for Worker thread id #41453

Merged
merged 2 commits into from
Jan 14, 2022
Merged

src: use std::optional for Worker thread id #41453

merged 2 commits into from
Jan 14, 2022

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 9, 2022

Refs: #41421

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. worker Issues and PRs related to Worker support. labels Jan 9, 2022
addaleax
addaleax commented Jan 9, 2022
View reviewed changes
src/node_worker.h

std::unique_ptr<InspectorParentHandle> inspector_parent_handle_;

// This mutex protects access to all variables listed below it.
mutable Mutex mutex_;

bool thread_joined_ = true;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here implied that this was protected by the mutex, but a) that didn’t reflect the actual usage of this field and b) it’s only ever accessed from the parent thread anyway, so no locking is necessary here

@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Jan 9, 2022
@addaleax addaleax mentioned this pull request Jan 9, 2022
Closed
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2022
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2022
mhdawson
mhdawson approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jan 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 13, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41848/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41857/

@github-actions github-actions bot mentioned this pull request Jan 14, 2022
Open
22 tasks
tniessen
tniessen approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41866/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41453
✔  Done loading data for nodejs/node/pull/41453
----------------------------------- PR info ------------------------------------
Title      src: use std::optional for Worker thread id (#41453)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     addaleax:41421-response -> nodejs:master
Labels     c++, author ready, worker
Commits    2
 - src: use std::optional for Worker thread id
 - fixup! src: use std::optional for Worker thread id
Committers 2
 - Anna Henningsen 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41453
Refs: https://github.com/nodejs/node/pull/41421
Reviewed-By: Tobias Nießen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41453
Refs: https://github.com/nodejs/node/pull/41421
Reviewed-By: Tobias Nießen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Jan 2022 18:55:39 GMT
   ✔  Approvals: 4
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-852398248
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-847354707
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-848035956
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-848089907
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-01-14T06:39:23Z: https://ci.nodejs.org/job/node-test-pull-request/41866/
- Querying data for job/node-test-pull-request/41866/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1697209985

@richardlau richardlau added dont-land-on-v16.x commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 14, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41453
✔  Done loading data for nodejs/node/pull/41453
----------------------------------- PR info ------------------------------------
Title      src: use std::optional for Worker thread id (#41453)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     addaleax:41421-response -> nodejs:master
Labels     c++, author ready, worker, dont-land-on-v12.x, dont-land-on-v14.x, dont-land-on-v16.x
Commits    2
 - src: use std::optional for Worker thread id
 - fixup! src: use std::optional for Worker thread id
Committers 2
 - Anna Henningsen 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41453
Refs: https://github.com/nodejs/node/pull/41421
Reviewed-By: Tobias Nießen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41453
Refs: https://github.com/nodejs/node/pull/41421
Reviewed-By: Tobias Nießen 
Reviewed-By: Rich Trott 
Reviewed-By: Colin Ihrig 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Jan 2022 18:55:39 GMT
   ✔  Approvals: 4
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-852398248
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-847354707
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-848035956
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41453#pullrequestreview-848089907
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2022-01-14T10:22:46Z: https://ci.nodejs.org/job/node-test-pull-request/41866/
- Querying data for job/node-test-pull-request/41866/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1698193651

RaisinTen
RaisinTen approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aduh95 aduh95 merged commit c22177f into nodejs:master Jan 14, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jan 14, 2022

Landed in c22177f

@github-actions github-actions bot mentioned this pull request Jan 15, 2022
Open
26 tasks
targos pushed a commit that referenced this pull request Jan 16, 2022
@addaleax @targos
src: use std::optional for Worker thread id
ec9071f 
Refs: #41421

PR-URL: #41453
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@targos targos mentioned this pull request Jan 16, 2022
Merged
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
@addaleax @mawaregetsuka
src: use std::optional for Worker thread id
a2aaaed 
Refs: nodejs#41421

PR-URL: nodejs#41453
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@addaleax @thedull
src: use std::optional for Worker thread id
58e840e 
Refs: nodejs#41421

PR-URL: nodejs#41453
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@addaleax @Linkgoron
src: use std::optional for Worker thread id
c102d01 
Refs: nodejs#41421

PR-URL: nodejs#41453
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@mhdawson mhdawson mhdawson approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @nodejs-github-bot @aduh95 @Trott @cjihrig @tniessen @mhdawson @RaisinTen @richardlau